-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Use official nvidia-ml-py package instead of fork #4208
Conversation
Hiya, sorry about the slow response! Mind if I push to fix the CI errors? |
Please do 😊 |
Ah, seems like there are real test failures caused by the dependency change, we'll probably have to go through and fix those. |
Tests are failing because they can't find the NVidia driver (cannot find |
It turns out the tests don't actually test the pynvml package. They just die because pynvml now throws a different exception when being imported. Should be fixed now. |
Test failures are dues to a bad pdm.lock file. I'm not familiar with pdm and just wanted to swap pynvml with nvidia-ml-py in pyproject.toml. What's the correct way to do that and re-generate the lock file? |
Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
The 3 failing checks don't look related to the changes in this MR. |
Yep. Our tests are just very much broken. |
Thanks. |
What does this PR address?
There are two packages in PyPI installing a
pynvml
module -pynvml
andnvidia-ml-py
. The former is a forked version of the latter, which is the official package published by NVIDIA.I stumbled upon this because I built a virtual environment that also installs
gpustat
, and that failed because that package pulls innvidia-ml-py
, thus overwriting the BentoML dependency.Before submitting:
guide on how to create a pull request.
pre-commit run -a
script has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.