fix(docs): remove eager type evaluation for python 3.8 on openllm examples #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
frostming
added a commit
that referenced
this pull request
Jan 16, 2024
Squashed commit of the following: commit b954ee7 Author: Ilia Bakalets <ilyabakalets12@gmail.com> Date: Thu Jan 11 12:42:37 2024 +0700 docs: fix typo in tritonserver_type parameter and code example (#4394) docs: fix typo in tritonserver_type parameter and address inconsistency in code example 1. There is a typo in tritonserver_type=''http' with double ' before http 2. for example "To get OUTPUT__1 as a JSON dictionary:", there is an inconsistency in the return line where it mentions OUTPUT_0, but it should be OUTPUT_1. commit 118be91 Author: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Date: Wed Jan 10 22:56:44 2024 -0500 fix(docs): remove eager type evaluation for python 3.8 (#4393) fix(docs): remove eager type evaluation for python 3.8 Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com> Signed-off-by: Frost Ming <me@frostming.com>
frostming
added a commit
that referenced
this pull request
Jan 16, 2024
* fix(docs): remove eager type evaluation for python 3.8 (#4393) fix(docs): remove eager type evaluation for python 3.8 Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com> * docs: fix typo in tritonserver_type parameter and code example (#4394) docs: fix typo in tritonserver_type parameter and address inconsistency in code example 1. There is a typo in tritonserver_type=''http' with double ' before http 2. for example "To get OUTPUT__1 as a JSON dictionary:", there is an inconsistency in the return line where it mentions OUTPUT_0, but it should be OUTPUT_1. --------- Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com> Co-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Co-authored-by: Ilia Bakalets <ilyabakalets12@gmail.com>
frostming
pushed a commit
that referenced
this pull request
Jan 17, 2024
fix(docs): remove eager type evaluation for python 3.8 Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.