Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set prometheus env before importing service #4875

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: set prometheus env before importing service #4875

merged 1 commit into from
Jul 23, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

@frostming
fix: set prometheus env before importing service
cd13a60 
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner July 23, 2024 02:11
@frostming frostming requested review from parano and removed request for a team July 23, 2024 02:11
@bojiang bojiang merged commit 49b66d7 into bentoml:main Jul 23, 2024
49 of 53 checks passed
@frostming frostming deleted the fix/metrics-env branch July 23, 2024 03:32
@aarnphm aarnphm mentioned this pull request Aug 27, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojiang bojiang bojiang approved these changes

@parano parano Awaiting requested review from parano parano is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frostming @bojiang