Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository and Deployment refactor and cleanup #771

Merged
merged 9 commits into from
Jun 9, 2020
Merged

Repository and Deployment refactor and cleanup #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cadd9e2
make sagemaker docker image have same file structure
parano Jun 9, 2020
b26acdb
use consistent file names
parano Jun 9, 2020
0d41836
move operator code out of __init__ to avoid loading unused code in mo…
parano Jun 9, 2020
5923fe1
refactor deployment validator
parano Jun 9, 2020
79d499c
reorganize bento repository code
parano Jun 9, 2020
8ec8fdf
deployment valiator test&linting error fix
parano Jun 9, 2020
fd32a17
more repository code cleanup
parano Jun 9, 2020
da9e216
renaming and adding inline comments
parano Jun 9, 2020
541c8ff
move out lambda operator code to separate file
parano Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bentoml/yatai/client/deployment_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
)
from bentoml.exceptions import BentoMLException, YataiDeploymentException
from bentoml.yatai.proto import status_pb2
from bentoml.yatai.validator import validate_deployment_pb_schema
from bentoml.yatai.validator import validate_deployment_pb
from bentoml.yatai.deployment_utils import (
deployment_yaml_string_to_pb,
deployment_dict_to_pb,
Expand Down Expand Up @@ -120,7 +120,7 @@ def create(self, deployment_info, wait):
)
)

validation_errors = validate_deployment_pb_schema(deployment_pb)
validation_errors = validate_deployment_pb(deployment_pb)
if validation_errors:
raise YataiDeploymentException(
f'Failed to validate deployment {deployment_pb.name}: '
Expand Down Expand Up @@ -168,7 +168,7 @@ def apply(self, deployment_info, wait):
)
)

validation_errors = validate_deployment_pb_schema(deployment_pb)
validation_errors = validate_deployment_pb(deployment_pb)
if validation_errors:
raise YataiDeploymentException(
f'Failed to validate deployment {deployment_pb.name}: '
Expand Down
Loading