Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] decode headers with latin1 #864

Merged
merged 1 commit into from
Jul 3, 2020
Merged

[FIX] decode headers with latin1 #864

merged 1 commit into from
Jul 3, 2020

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Jul 3, 2020

Description

ref: benoitc/gunicorn#1778

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #864 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   60.69%   60.70%           
=======================================
  Files         118      118           
  Lines        7959     7960    +1     
=======================================
+ Hits         4831     4832    +1     
  Misses       3128     3128           
Impacted Files Coverage Δ
bentoml/adapters/dataframe_input.py 74.07% <ø> (ø)
bentoml/adapters/base_input.py 84.21% <100.00%> (ø)
bentoml/marshal/utils.py 60.81% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0846b6b...77f291a. Read the comment docs.

@parano parano merged commit 88dd398 into bentoml:master Jul 3, 2020
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants