This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
fix: calling the bentoml's track() with incorrect CliEvent #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
reviewed
Jul 7, 2022
| # These are internal apis. We will need to make sure update these when BentoML changes. | ||
| from bentoml._internal.utils.analytics.schemas import EventMeta |
There was a problem hiding this comment.
cc @ssheng another point we need to consider when discussing about API exposure post 1.0
There was a problem hiding this comment.
Maybe a bentoml_util project will be needed for common libraries within our projects.
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 60.27% 59.29% -0.98%
==========================================
Files 24 24
Lines 1110 1113 +3
==========================================
- Hits 669 660 -9
- Misses 441 453 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
aarnphm
approved these changes
Jul 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Curently bentoctl CliEvent is not defined with attrs and hence does not get serialized completely
when calling
track()function in bentoml.closes: