Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

feat: using poetry to manage dependencies #51

Merged
merged 1 commit into from
Dec 13, 2021
Merged

feat: using poetry to manage dependencies #51

merged 1 commit into from
Dec 13, 2021

Conversation

jjmachan
Copy link
Contributor

@jjmachan jjmachan commented Dec 13, 2021

using poetry to pin all our dependencies. #45

poetry is used for:

  • managing the dependency version
  • managing building and publishing to pypi

@jjmachan
Copy link
Contributor Author

need to decide upon the authentication method we would like to use for the release scripts. These are the available ones and https://python-poetry.org/docs/repositories/#configuring-credentials

@jjmachan
Copy link
Contributor Author

we can also consider removing the setup.py file completely since poetry covers most of it.

@yubozhao
Copy link
Contributor

For now, it will encounter issue when uploading, because of bentoml 1.0 is not release yet

UploadError

  HTTP Error 400: Invalid value for requires_dist. Error: Can't have direct dependency: 'bentoml @ git+https://github.com/bentoml/BentoML@main'

  at /opt/homebrew/Cellar/poetry/1.1.12/libexec/lib/python3.10/site-packages/poetry/publishing/uploader.py:216 in _upload
      212│                     self._register(session, url)
      213│                 except HTTPError as e:
      214│                     raise UploadError(e)
      215│
    → 216│             raise UploadError(e)
      217│
      218│     def _do_upload(
      219│         self, session, url, dry_run=False
      220│     ):  # type: (requests.Session, str, Optio

^ it is not a blocker for now, since we are not releasing this yet. We can merge it for now, and note it for when we releasing

@yubozhao yubozhao merged commit 27d6f31 into main Dec 13, 2021
@yubozhao yubozhao deleted the poetry branch December 13, 2021 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants