This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
GitOps refactor #93
Merged
GitOps refactor #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yubozhao
commented
Mar 21, 2022
bentoctl/deployment_config.py
Outdated
Comment on lines
40
to
44
| "type": { | ||
| "required": True, | ||
| "default": "terraform", | ||
| "help_message": "The type of deployment project to use", | ||
| } |
There was a problem hiding this comment.
change it to template_type
yubozhao
commented
Mar 21, 2022
bentoctl/deployment_config.py
Outdated
| v = cerberus.Validator() | ||
| validated_spec = v.validated(copied_operator_spec, schema=operator_schema) | ||
| if validated_spec is None: | ||
| raise InvalidDeploymentConfig(config_errors=v.errors) | ||
| self.operator_spec = validated_spec | ||
|
|
||
| def generate(self): | ||
| self.operator.generate( |
There was a problem hiding this comment.
check the template type
yubozhao
commented
Mar 29, 2022
bentoctl/cli/__init__.py
Outdated
Comment on lines
132
to
137
| build_docker_image( | ||
| image_tag=image_tag, | ||
| context_path=dockercontext_path, | ||
| dockerfile=dockerfile_path, | ||
| additional_build_args=build_args, | ||
| ) |
There was a problem hiding this comment.
this should be determined by the push flag, if user decided not to push, we can also create a docker image file in the current directory (that could be a flag too)
jjmachan
reviewed
Mar 31, 2022
bentoctl/cli/__init__.py
Outdated
Comment on lines
101
to
109
| @click.option("--registry-password") | ||
| @click.option("--registry-username") | ||
| @click.option("--debug", is_flag=True, default=False) | ||
| def build( | ||
| bento_tag, | ||
| deployment_config_file, | ||
| push, | ||
| overwrite_deployable, | ||
| registry_username, | ||
| registry_password, | ||
| debug, |
There was a problem hiding this comment.
we already have debug functionality setup for all commands. Its sets an env-var to signify it and changes logging mode to debug
yubozhao
commented
Mar 31, 2022
yubozhao
commented
Mar 31, 2022
yubozhao
commented
Mar 31, 2022
yubozhao
commented
Mar 31, 2022
bentoctl/deployment_config.py
Outdated
| bento_name=self.bento.tag.name, | ||
| spec=self.operator_spec, | ||
| ) | ||
| self.operator_spec["repository_name"] = self.bento.tag.name |
There was a problem hiding this comment.
@jjmachan make sure we need this, check it with lambda
yubozhao
commented
Mar 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.