-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(monitor-exporter): add fluentbit exporter #79
Conversation
39e51fc
to
6f61e0b
Compare
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
@@ -2244,6 +2294,41 @@ func (r *BentoDeploymentReconciler) generatePodTemplateSpec(ctx context.Context, | |||
podSpec.Containers = append(podSpec.Containers, extraPodSpec.Containers...) | |||
} | |||
|
|||
if need_monitor_container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the OTEL_*
environment variables for the main container when we add the monitor container?
https://opentelemetry.io/docs/reference/specification/sdk-environment-variables/
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
/run-e2e |
LGTM |
Example bento: https://default.cloud.bentoml.com/bento_repositories/monitor_example_classification/bentos/dhumdqufzwcciusu
Example CR: