Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(monitor-exporter): add fluentbit exporter #79

Merged
merged 4 commits into from
Dec 30, 2022
Merged

feat(monitor-exporter): add fluentbit exporter #79

merged 4 commits into from
Dec 30, 2022

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Dec 27, 2022 •
edited

Example bento: https://default.cloud.bentoml.com/bento_repositories/monitor_example_classification/bentos/dhumdqufzwcciusu
Example CR:

apiVersion: serving.yatai.ai/v1alpha3
kind: BentoDeployment
metadata:
  name: my-bento-deployment
  namespace: my-namespace
spec:
  bento_tag: monitor_example_classification:dhumdqufzwcciusu
  ingress:
    enabled: true
  resources:
    limits:
        cpu: 2000m
        memory: "1Gi"
    requests:
        cpu: 1000m
        memory: "1Gi"
  runners:
  - name: iris_clf
    resources:
      limits:
        cpu: 2000m
        memory: "1Gi"
      requests:
        cpu: 1000m
        memory: "1Gi"
monitorExporter:
  enabled: true
  output: stdout
  options:
    workers: 4

yetone
yetone reviewed Dec 27, 2022
View reviewed changes
.gitignore Show resolved Hide resolved
@yetone yetone force-pushed the v1.1.0 branch 4 times, most recently from 39e51fc to 6f61e0b Compare December 28, 2022 03:46
@yetone yetone changed the base branch from v1.1.0 to main December 28, 2022 03:57
@yetone yetone changed the base branch from main to v1.1.0 December 28, 2022 04:50
@bojiang bojiang changed the base branch from v1.1.0 to main December 28, 2022 04:53
@yetone
Copy link
Member

yetone commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@yetone
Copy link
Member

yetone commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here
Update: You can check the progress here

yetone
yetone reviewed Dec 28, 2022
View reviewed changes
images/fluentbit/Dockerfile Show resolved Hide resolved
controllers/bentodeployment_controller.go Show resolved Hide resolved
controllers/bentodeployment_controller.go
@@ -2244,6 +2294,41 @@ func (r *BentoDeploymentReconciler) generatePodTemplateSpec(ctx context.Context,
podSpec.Containers = append(podSpec.Containers, extraPodSpec.Containers...)
}

if need_monitor_container {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the OTEL_* environment variables for the main container when we add the monitor container?

https://opentelemetry.io/docs/reference/specification/sdk-environment-variables/

@yetone
Copy link
Member

yetone commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@yetone
Copy link
Member

yetone commented Dec 28, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 29, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 30, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@bojiang
Copy link
Member Author

bojiang commented Dec 30, 2022 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@yetone
Copy link
Member

yetone commented Dec 30, 2022

LGTM

@yetone yetone merged commit 2e86b1a into bentoml:main Dec 30, 2022
@bojiang bojiang deleted the v2.x branch April 11, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yetone yetone yetone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bojiang @yetone