collection: add individual researcher message #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saracarl
requested changes
Jan 8, 2020
diegoviola
force-pushed
the
1560-individual-researcher-message
branch
3 times, most recently
from
73e3d0b
to
4396ca2
Compare
saracarl
requested changes
Jan 13, 2020
There was a problem hiding this comment.
-
The logic should be "show the warning OR show the collection creation form" -- right now, we are showing both to individual researchers. So they can ignore the warning and go ahead and create a collection, which I don't want.
-
Remove the comma from this string:
To upgrade your account, contact support@fromthepage.com.
becomes
To upgrade your account contact support@fromthepage.com.
|
Tests passed locally, though! |
diegoviola
force-pushed
the
1560-individual-researcher-message
branch
12 times, most recently
from
e985b7b
to
0dd027b
Compare
diegoviola
force-pushed
the
1560-individual-researcher-message
branch
from
0dd027b
to
7158706
Compare
|
We still need to hide the form if we display the warning message. |
|
@benwbrum done. Note that I had to change the account_type to "Trial" for those specific tests, otherwise the form gets disabled and causes the tests to break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.