Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1578 add formats export all works #1579

Merged
merged 24 commits into from
Feb 13, 2020
Merged

Conversation

diegoviola
Copy link
Contributor

No description provided.

@saracarl
Copy link
Collaborator

saracarl commented Jan 7, 2020

  1. Description in the UI currently says: "containing each work as an XHTML file with transcripts, user comments, subject articles, and internal HREFs linking subjects and pages." and needs to be changed to say "containing each work as HTML and plain text.
  2. The old .xhtml file needs to be removed from the zip file -- the html directory serves that purpose.
  3. If no translation enabled for the work, do not include any _translation files or folders.
  4. If subject linking is disabled, do not include any _emended files or folders.
  5. The README should only contain a description of what each type of file is. It should not list every file.

HTML:
full -- full text of the transcription or translation, with versions, contributors, and comments.
text -- just the full text of the transcription or translation

Text:
verbatim -- full text of the transcription, with versions, contributors and comments.
searchable -- links removed and line breaks removed so searches can span line breaks.
emended -- replaces linked subjects' verbatim with canonical subject names. Useful for text analysis.

@diegoviola diegoviola force-pushed the 1578-add-formats-export-all-works branch from dfa2274 to 5646ce8 Compare January 10, 2020 04:29
@diegoviola diegoviola changed the base branch from development to rails6 January 11, 2020 08:07
@saracarl saracarl assigned saracarl and unassigned diegoviola and benwbrum Jan 14, 2020
@saracarl
Copy link
Collaborator

I'm getting a:

No route matches {:action=>"export_work", :collection_id=>"iiif-showcase-2018", :controller=>"export", :format=>:zip, :user_slug=>"saracarl", :work_id=>15367}

For anything I try to export.

@saracarl saracarl assigned diegoviola and unassigned saracarl Jan 21, 2020
@saracarl saracarl assigned saracarl and unassigned diegoviola Jan 28, 2020
@saracarl saracarl assigned diegoviola and unassigned saracarl Jan 30, 2020
@saracarl
Copy link
Collaborator

saracarl commented Feb 4, 2020

Let's also change the emended_transcript and emended_translation filenames to be expanded_transcript and expanded_translation. The README should also explain them:
Expanded transcripts and translations replace the verbatim linked subjects with the canonical name of the subject to make it suitable for text analysis.

@diegoviola
Copy link
Contributor Author

@saracarl I just added the changes you suggested, please give it a try.

@diegoviola diegoviola assigned saracarl and unassigned diegoviola Feb 4, 2020
@saracarl
Copy link
Collaborator

saracarl commented Feb 4, 2020

Error when I tried to export all works:

uninitialized constant ExportController::README
Did you mean?  Readline```

@saracarl saracarl assigned diegoviola and unassigned saracarl Feb 4, 2020
@diegoviola
Copy link
Contributor Author

Error when I tried to export all works:

uninitialized constant ExportController::README
Did you mean?  Readline```

@saracarl I can't reproduce this error, are you sure you're seeing this with the latest commit?

@diegoviola diegoviola assigned saracarl and unassigned diegoviola Feb 6, 2020
@saracarl
Copy link
Collaborator

The html directories for each work have a translation.html even if translation is not enabled. We need to remove those.

@saracarl saracarl assigned diegoviola and unassigned saracarl Feb 12, 2020
before exporting (we already do this for plaintext, but also do the same
for HTML content).
@diegoviola
Copy link
Contributor Author

The html directories for each work have a translation.html even if translation is not enabled. We need to remove those.

@saracarl please try a7c7556.

@diegoviola diegoviola assigned saracarl and unassigned diegoviola Feb 12, 2020
@saracarl saracarl merged commit 82e3184 into rails6 Feb 13, 2020
@saracarl saracarl deleted the 1578-add-formats-export-all-works branch February 13, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants