-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified owner dashboard and added collection progress bars for #3619 #3672
Conversation
255d589
to
24d2ff9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Could you also test the UI for when an owner has no collections? This is the case where an owner is brand new; I'd like to confirm we still send them to the "Start a Project" once they get the account created, but also that if they end up here there is a message of some sort with a link to Start a Project.
I also restarted the failing tests, since they were failing due to an InternetArchive problem.
Here's how it looks, this wasn't changed in this PR. |
Nope, that's fine @sylvieed. I just wanted to make sure we didn't have regressions that would fail in the common and very important new owner scenario. This is great -- I really like how the Active/Inactive headers disappear if you only one of those 2 types. |
There's still failing tests, 3 of them. They are all failing with this because of the UI changes:
|
Yeah, right now it's actually failing to find the work on the collection show page. It's tricky for me to debug the tests because I can't run them locally, so I've just trying to guess & check |
Resolves #3619 (and #3590, #3205)
This improves and simplifies the owner dashboard.
Changes
The logic for these last two statistics are based on the corresponding logic for the work progress bars on the collection show page.