Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2139-Version comparison diff view is made clearer for reverse chronological order comparison #3690

Merged

Conversation

symmetrically
Copy link
Contributor

No description provided.

@benwbrum benwbrum linked an issue Jul 13, 2023 that may be closed by this pull request
@benwbrum
Copy link
Owner

benwbrum commented Jul 18, 2023

My Setup:

Observed behavior

  • Select the version with the added equals signs and compare it with an earlier version: all looks fine (fig. 1)
  • Now compare it with a later version: the "Title" text which was added in the later version looks like it was deleted (fig. 2)

We need to make another pass at this following these principles

  • Text added in a later version always appears as green compared to text in an earlier version
  • Text deleted in a later version always appears as red/strike-through compared to text in an earlier version

Figure 1

Screenshot from 2023-07-18 11-12-22

Figure 2

Screenshot from 2023-07-18 11-12-37

@benwbrum benwbrum merged commit 5887ec4 into development Aug 8, 2023
1 check passed
@benwbrum benwbrum deleted the 2139-enforce-chronological-order-in-comparison-diff branch August 8, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version comparison diff view should enforce chronological order
2 participants