Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the wrong description about polard binary #1338

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: fix the wrong description about polard binary #1338

merged 1 commit into from
Nov 30, 2023

Conversation

lilasxie
Copy link
Contributor

@lilasxie lilasxie commented Nov 30, 2023 •
edited by coderabbitai bot

Currently, run make will generate a polard binary under ./build/bin/, and run polard --help will show the wrong description

image

This pr fix this

image

Summary by CodeRabbit

  • Refactor
    • Updated the command-line interface naming and description to reflect the Polaris node daemon and interaction capabilities.

@lilasxie
fix: fix the wrong description about polard binary
ac3f125 
Signed-off-by: lilas <30857671+lilasxie@users.noreply.github.com>
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 30, 2023 •
edited

Walkthrough

The update reflects a rebranding or refactoring effort where the command-line interface's name and description have been changed. The previous command "simd" associated with a simulation app has been renamed to "polard," which now relates to a node daemon and CLI for interacting with a Polaris node.

Changes

File Path Change Summary
e2e/testapp/polard/cmd/root.go Renamed command from "simd" to "polard" and updated the short description accordingly.

🐇✨
In the realm of code, a change took flight,
From "simd" to "polard," through the digital night.
A node daemon awakens with a new tale,
In the Polaris sky, it sets sail. 🌌🚀

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@itsdevbear itsdevbear added merge me daddy Trigger Beradozer to bulldoze the PR backport/v0.0.2-alpha labels Nov 30, 2023
@itsdevbear
Copy link
Member

ty for the contribution!!!!

@mergify mergify bot merged commit 43774ce into berachain:main Nov 30, 2023
10 checks passed
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
@lilasxie @mergify
fix: fix the wrong description about polard binary (#1338)
2c0480c 
Currently, run `make` will generate a `polard` binary under ./build/bin/, and run `polard --help` will show the wrong description

![image](https://github.com/berachain/polaris/assets/30857671/dee6f749-4757-42ee-a11a-bc8b979b470a)

This pr fix this

![image](https://github.com/berachain/polaris/assets/30857671/97558c36-1375-4a6a-84d3-ef6beb9a54d4)

## Summary by CodeRabbit

- **Refactor**
  - Updated the command-line interface naming and description to reflect the Polaris node daemon and interaction capabilities.

(cherry picked from commit 43774ce)
@mergify mergify bot mentioned this pull request Nov 30, 2023
Merged
@lilasxie lilasxie deleted the fix/polard-description branch November 30, 2023 15:21
itsdevbear pushed a commit that referenced this pull request Nov 30, 2023
@mergify @lilasxie
fix: fix the wrong description about polard binary (backport #1338) (…
cdd0796 
…#1339)

This is an automatic backport of pull request #1338 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: lilas <30857671+lilasxie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdevbear itsdevbear itsdevbear approved these changes

Assignees
No one assigned
Labels
backport/v0.0.2-alpha merge me daddy Trigger Beradozer to bulldoze the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lilasxie @itsdevbear