forked from KristianOellegaard/django-hvad
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hidden input on admin model editor, to allow django-cms placeholder p…
…lugin js editor to get current language
- Loading branch information
Showing
1 changed file
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf4be06
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't this be added as title on the span element, so we dont need a new element here?
cf4be06
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it could, and would be a much better solution.
The motivation to have done it this way is to not have to modify django-cms code (plugin_editor.js).
As this js currently does:
But you are right, I will do things well, and make a pull request on both projects.
Thank you