Skip to content

Commit

Permalink
Merge pull request #1475 from jkeiser/jk/solve-2.0
Browse files Browse the repository at this point in the history
Upgrade to solve 2.0
  • Loading branch information
reset committed Nov 9, 2015
2 parents 3112f37 + 98dad6d commit 08f84e2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions berkshelf.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ Gem::Specification.new do |s|
s.add_dependency 'minitar', '~> 0.5.4'
s.add_dependency 'retryable', '~> 2.0'
s.add_dependency 'ridley', '~> 4.3'
s.add_dependency 'solve', '~> 1.1'
s.add_dependency 'solve', '~> 2.0'
s.add_dependency 'dep_selector', '~> 1.0'
s.add_dependency 'thor', '~> 0.19'
s.add_dependency 'octokit', '~> 4.0'
s.add_dependency 'celluloid', '= 0.16.0'
Expand All @@ -50,7 +51,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'aruba', '~> 0.6'
s.add_development_dependency 'chef-zero', '~> 4.0'
s.add_development_dependency 'fuubar', '~> 2.0'
s.add_development_dependency 'rake', '~> 0.9'
s.add_development_dependency 'rake', '~> 10.1'
s.add_development_dependency 'rspec', '~> 3.0'
s.add_development_dependency 'spork', '~> 0.9'
s.add_development_dependency 'test-kitchen', '~> 1.2'
Expand Down
2 changes: 2 additions & 0 deletions lib/berkshelf/resolver.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
module Berkshelf
class Resolver
Solve.engine = :gecode

This comment has been minimized.

Copy link
@martinisoft

martinisoft Nov 16, 2015

Contributor

I'd love to see this be kept as an option if possible. I currently cannot use the gecode resolver without it locking up. Keeping this to a "if you have 'dep_selector' present then we will use gecode" option would be better if that could be done.

This comment has been minimized.

Copy link
@reset

reset Nov 16, 2015

Author Contributor

This is set here by default as a first pass. As the other resolver is vetted then it may become the new default. The gecode solver is currently the only solver which 100% matches resolutions with the Chef Server because the Chef Server incorrectly solves graphs.


require_relative 'resolver/graph'

extend Forwardable
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/berkshelf/berksfile_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@
describe '#cookbooks' do
it 'raises an exception if a cookbook is not installed' do
subject.add_dependency('bacon', nil)
expect { subject.cookbooks }.to raise_error
expect { subject.cookbooks }.to raise_error(Berkshelf::DependencyNotFound)
end

it 'retrieves the locked (cached) cookbook for each dependency' do
Expand Down

0 comments on commit 08f84e2

Please sign in to comment.