Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the forgotten :graphviz tag in visualizer_spec. #1291

Merged
merged 1 commit into from
Aug 25, 2014

Conversation

sersut
Copy link

@sersut sersut commented Aug 25, 2014

We have detected this in our Chef DK tests which disable visualizer specs since graphviz is not included with Chef DK. Currently we are running berks specs like this. One of the examples are failing since it requires graphviz but not tagged correctly:

Failures:

  1) Berkshelf::Visualizer#to_png when the graphviz command succeeds builds a png from a Lockfile
     Failure/Error: Unable to find matching line from backtrace
     Berkshelf::GraphvizNotInstalled:
       Berkshelf::GraphvizNotInstalled
     # /opt/chefdk/embedded/apps/berkshelf/lib/berkshelf/visualizer.rb:92:in `to_png'
     # /opt/chefdk/embedded/apps/berkshelf/spec/unit/berkshelf/visualizer_spec.rb:35:in `block (4 levels) in <module:Berkshelf>'

sethvargo added a commit that referenced this pull request Aug 25, 2014
Include the forgotten :graphviz tag in visualizer_spec.
@sethvargo sethvargo merged commit 83a6e84 into berkshelf:master Aug 25, 2014
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants