-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cookbook uploads without dependency resolution. Add spec. #296
Conversation
@@ -188,6 +188,11 @@ def update(*cookbook_names) | |||
default: false, | |||
desc: "Skip Ruby syntax check when uploading cookbooks", | |||
aliases: "-s" | |||
option :nodeps, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally prefer if this were :no_dependencies
(--no-dependencies
). I think it's far better to be specific. --nodeps
isn't very informative. You already have the "short-form" -D
.
Allow cookbook uploads without dependency resolution. Add spec.
@reset @sethvargo updated option name and added custom class/exit code in the branch this pull request was based on if it would be useful. |
@chrisroberts reverted this initial PR.
This error message is not clear enough to why the upload failed. The expected behavior from the description of the CLI flag is that the explicitly defined cookbooks in the Berksfile (in this case, artifact and build-essential) would be uploaded but their dependencies would be skipped. |
solution = resolve(options) | ||
|
||
if(options[:nodeps]) | ||
r = resolver(options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can clean this up, but please take a look at the surrounding code and match the style.
- no single letter variables
- no parentheses around parameters to control statements (if, then, else)
- do/end on multiline blocks
prefer the |
No description provided.