Add Cane

[justincampbell]

• Can be invoked with cane or thor spec quality
• Settings are in .cane
• Currently allowing violations for our current codebase
• Will fail the build if quality or coverage gets any worse

[justincampbell]

Current violations, for funsies:

Methods exceeded maximum allowed ABC complexity (18):

  lib/berkshelf/installer.rb                    Berkshelf::Installer#install                                  35
  lib/berkshelf/berksfile.rb                    Berkshelf::Berksfile#sources                                  32
  lib/berkshelf/command.rb                      Berkshelf::Command#filter                                     28
  lib/berkshelf/locations/chef_api_location.rb  Berkshelf::ChefAPILocation#initialize                         27
  lib/berkshelf/installer.rb                    Berkshelf::Installer#vendor                                   27
  lib/berkshelf/cli.rb                          Berkshelf::Cli#upload                                         26
  lib/berkshelf/cookbook_source.rb              Berkshelf::CookbookSource#initialize                          22
  lib/berkshelf/vagrant/action/upload.rb        Berkshelf::Vagrant::Action::Upload#upload                     20
  lib/berkshelf/resolver.rb                     Berkshelf::Resolver#use_source                                19
  lib/berkshelf/berksfile.rb                    Berkshelf::Berksfile#upload                                   19
  lib/berkshelf/cli.rb                          Berkshelf::Cli#configure                                      18
  lib/berkshelf/vagrant.rb                      Berkshelf::Vagrant#init!                                      17
  lib/berkshelf/berksfile.rb                    Berkshelf::Berksfile#metadata                                 17
  lib/berkshelf/vagrant/config.rb               Berkshelf::Vagrant::Config#validate                           17
  lib/berkshelf/vagrant/action/install.rb       Berkshelf::Vagrant::Action::Install#configure_cookbooks_path  16
  lib/berkshelf/berksfile.rb                    Berkshelf::Berksfile#outdated                                 16
  lib/berkshelf/cli.rb                          Berkshelf::Cli#outdated                                       16
  lib/berkshelf/cookbook_generator.rb           Berkshelf::CookbookGenerator#generate                         16

Class definitions require explanatory comments on preceding line (6):

  lib/berkshelf/core_ext/file.rb:1                    File
  lib/berkshelf/core_ext/pathname.rb:1                Pathname
  lib/berkshelf/core_ext/string.rb:1                  String
  lib/berkshelf/lockfile.rb:2                         Lockfile
  lib/thor/monkies/hash_with_indifferent_access.rb:1  Thor
  lib/thor/monkies/hash_with_indifferent_access.rb:3  HashWithIndifferentAccess

Total Violations: 24

[justincampbell]

This excludes "line over 80 character" warnings

[reset]

I've been following 120 character limits pretty much. Do you want to set it to that and check for it?

[justincampbell]

@reset Done. There are a few over, but I also updated the max-violations to match.

[sethvargo]

#awkard... I wrote most of those methods.

[justincampbell]

@sethvargo Ha! No finger pointing here, just trying to get better at this stuff :p

[sethvargo]

👍

[reset]

I'd like to merge this once we've got the build passing for it's current failures. After merging this we will have all new potential reasons for our build to fail and I'd like to keep the problem surface smaller for now ;)

[justincampbell]

Sounds good to me. We can shelve it for a bit.

-Justin

On Wednesday, February 6, 2013 at 8:44 PM, Jamie Winsor wrote:

I'd like to merge this once we've got the build passing for it's current failures. After merging this we will have all new potential reasons for our build to fail and I'd like to keep the problem surface smaller for now ;)

—
Reply to this email directly or view it on GitHub (#333 (comment)).

[sethvargo]

sherf* it for a bit 😄

[justincampbell]

@reset This is ready for review again, rebased off of master