Add Cane

.cane

@@ -0,0 +1,4 @@
+--doc-exclude lib/berkshelf/errors.rb
+--max-violations 100
+--style-measure 120
+--parallel

Gemfile

@@ -5,6 +5,7 @@ gemspec
 group :development do
   gem 'coolline'
   gem 'guard', '>= 1.5.0'
+  gem 'guard-cane'
   gem 'guard-cucumber'
   gem 'guard-rspec'
   gem 'guard-spork'

Guardfile

@@ -23,3 +23,7 @@ guard 'cucumber', cli: "--drb --format pretty --tags ~@no_run --tags ~@wip", all
 
   watch(%r{^lib/berkshelf/cli.rb})                      { 'features' }
 end
+
+guard 'cane' do
+  watch(/.*\.rb/)
+end

Thorfile

@@ -38,15 +38,15 @@ class Default < Thor
 
     desc "all", "Run all tests"
     def all
-      unless run_unit && run_acceptance
+      unless run_unit && run_acceptance && run_quality
         exit 1
       end
     end
 
     desc "ci", "Run all possible tests on Travis-CI"
     def ci
       ENV['CI'] = 'true' # Travis-CI also sets this, but set it here for local testing
-      unless run_unit("--tag ~chef_server") && run_acceptance("--tags ~@chef_server")
+      unless run_unit("--tag ~chef_server") && run_acceptance("--tags ~@chef_server") && run_quality
         exit 1
       end
     end
@@ -65,6 +65,13 @@ class Default < Thor
       end
     end
 
+    desc "quality", "Run quality tests"
+    def quality
+      unless run_quality
+        exit 1
+      end
+    end
+
     no_tasks do
       def run_unit(*flags)
         run "rspec --color --format=documentation #{flags.join(' ')} spec"
@@ -73,6 +80,10 @@ class Default < Thor
       def run_acceptance(*flags)
         run "cucumber --color --format pretty --tags ~@no_run #{flags.join(' ')}"
       end
+
+      def run_quality
+        run "cane --gte coverage/.last_run.json,90"
+      end
     end
   end
 

berkshelf.gemspec

@@ -45,6 +45,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'net-ssh-gateway', '= 1.1.0'
 
   s.add_development_dependency 'aruba'
+  s.add_development_dependency 'cane'
   s.add_development_dependency 'json_spec'
   s.add_development_dependency 'rake', '>= 0.9.2.2'
   s.add_development_dependency 'rspec'