Executable #4
Merged
Executable #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,19 +9,25 @@ def initialize name, constraint_string=">= 0.0.0" | |||
| @version_constraint = DepSelector::VersionConstraint.new(constraint_string) | |||
| end | |||
|
|
|||
| def download | |||
| def download | |||
|
Looks good. But don't hate me for suggesting this... How about we make a 'knife remy' plugin instead? It makes a lot of sense and what you have here should be easy to port, and we can get all the config-oriented commandline stuff for free. |
|
I don't see why not. It's already mostly powered by Knife, anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/remy