This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Configure appveyor #357
Merged
Configure appveyor #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 13, 2016 11:49
Signed-off-by: Thom May <thom@may.lt>
Signed-off-by: Thom May <thom@may.lt>
Signed-off-by: Thom May <thom@may.lt>
thommay
force-pushed
the
tm/appveyor
branch
from
ebc31ad
to
14e8c7e
Compare
added 2 commits
September 14, 2016 12:56
0.0.0.0 isn't a valid address on windows Signed-off-by: Thom May <thom@may.lt>
Signed-off-by: Thom May <thom@chef.io>
thommay
force-pushed
the
tm/appveyor
branch
from
a4c0c69
to
433318d
Compare
Signed-off-by: Thom May <thom@chef.io>
|
@mwrock I'd appreciate review of this; especially writing the metadata.json as binary to force it LF rather than CRLF; I can't imagine what harm that would do but still… (this should get squashed before merge) |
|
👍 LGTM Simply writing to an ascii file should not automatically insert CRs on windows unless the content actually has CRs already in it. but I don't see harm in forcing it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thom May thom@may.lt