Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/2 - Set up PSR autoloader and Composer #6

Closed
wants to merge 3 commits into from
Closed

Issue/2 - Set up PSR autoloader and Composer #6

wants to merge 3 commits into from

Conversation

alexstandiford
Copy link
Collaborator

This moves all files so that the structure works with PSR autoloading. I went ahead and added the composer.json file.

issue #2

Also issue #5

@sc0ttkclark
Copy link

I'd prefer to see capitalization in the folder structure to match the namespace like Database/Etc/Etc/Class.php to follow PSR-4 standards there.

@alexstandiford
Copy link
Collaborator Author

@sc0ttkclark - could you take another look and see if this works in your composer setup? It's working over here. I went ahead and updated it to match that. Good catch.

@@ -0,0 +1,334 @@
<?php

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky but the file location is database not Database which Git has hacky ways to get around and fix

@JJJ
Copy link
Collaborator

JJJ commented Nov 25, 2019

This has conflicts that need resolving. Anyone able to refresh it?

@szepeviktor
Copy link
Contributor

return $anyone === '@alexstandiford';

@alexstandiford
Copy link
Collaborator Author

We can probably close this PR in-favor of #49

@JJJ JJJ closed this Jun 30, 2020
@JJJ JJJ added this to the 2.0.0 milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants