Merge pull request #10 from johanneswuerbach/close-callback

Adds missing close callback.
bermi · Jul 16, 2013 · 3866a00 · 3866a00
2 parents 095ee26 + 2b7a810
commit 3866a00
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/sauce-connect-launcher.js b/lib/sauce-connect-launcher.js
@@ -190,7 +190,12 @@ function run(options, callback) {
 
   openProcesses.push(child);
 
-  child.close = function () {
+  child.close = function (closeCallback) {
+    if (closeCallback) {
+      child.on("close", function () {
+        closeCallback();
+      });
+    }
     child.kill("SIGTERM");
   };
 }

diff --git a/test/sauce-connect-launcher.test.js b/test/sauce-connect-launcher.test.js
@@ -90,6 +90,16 @@ describe("Sauce Connect Launcher", function () {
         done();
       });
     });
+
+    it("should execute a provided close callback", function (done) {
+      sauceConnectLauncher(sauceCreds, function (err, sauceConnectProcess) {
+        if (err) { throw err; }
+        expect(sauceConnectProcess).to.be.ok();
+        sauceConnectProcess.close(function () {
+          done();
+        });
+      });
+    });
   }
 
 });