Fix reporting exit code 143 as an error closing Sauce Connect #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bermi
added a commit
that referenced
this pull request
Jul 24, 2013
Fix reporting exit code 143 as an error closing Sauce Connect
|
Thank you, I just pushed v0.1.11 to npm with these changes. |
bryanforbes
pushed a commit
to bryanforbes/intern
that referenced
this pull request
Jan 14, 2014
This manifests as an exit code 143 error. See <bermi/sauce-connect-launcher#12>
stdavis
pushed a commit
to stdavis/intern
that referenced
this pull request
Jun 22, 2015
This manifests as an exit code 143 error. See <bermi/sauce-connect-launcher#12>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to terminate Sauce Connect when
closeis called, aSIGTERMis sent to the child Java process. Java will receive theSIGTERM, shut down, and return an exit code of 143. This is not an error, so this pull request stops it from being reported as an error.