Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sideloaded apps misinterpreted as system apps #11

Closed
Madis0 opened this issue Mar 6, 2019 · 15 comments
Closed

Sideloaded apps misinterpreted as system apps #11

Madis0 opened this issue Mar 6, 2019 · 15 comments

Comments

@Madis0
Copy link

Madis0 commented Mar 6, 2019

I have several apps which I have either sideloaded or restored by root (app and app data) with oandbackup which are misrepresented as system apps by SDKMonitor.

Not sure what additional data I can provide to help you, app/package names likely wouldn't help.

Related: #5

@bernaferrari
Copy link
Owner

So.. This is complicated. I considered system app anything that wasn't installed from play store and anything that wasn't installed manually (by package installer). If I consider anything that has a known origin, there system apps that will be shown, because in my scenario a lot of Samsung apps have a known origin, Samsung installed them.

If you really want, I can change the algorithm to anything that has known origin, but be aware bloat or system apps will appear too.

@Madis0
Copy link
Author

Madis0 commented Mar 6, 2019

Are you sure you are not mixing system apps with pre-installed apps in your thought? Even if there are apps that can not be uninstalled or disabled, they aren't system unless defined as so (different partition, I guess?).

In other words, yes, go for it.

@bernaferrari
Copy link
Owner

Fixed on last version (was already fixed a few weeks ago, but since I never generated an apk for that version..)!

@Madis0
Copy link
Author

Madis0 commented Apr 6, 2019

The latest update seemed to slightly increase the number of apps shown, but it still isn't correct, even after clearing SDKMonitor's app data.

SDKMonitor claims I have 117 user apps, AppChecker claims I have 153.
(For reference, the OS claims I have 177 but it seems it actually includes some system-y apps that may not be "systemly" critical, but still pre-installed.)

@bernaferrari
Copy link
Owner

bernaferrari commented Apr 6, 2019 via email

@Madis0
Copy link
Author

Madis0 commented Apr 6, 2019

SDMaid - 153
OpenAPK (source) - 154 (+1 because I installed it lol)

The latter is open source, so it might help.

@bernaferrari
Copy link
Owner

Technically I should never look at gpl code because I'm using Apache 2, unless @dkanada allows.. But I found he is using PackageManager.GET_META_DATA instead of 0 I was using and that returns a few more results - probably what you want.

@Madis0
Copy link
Author

Madis0 commented Apr 6, 2019

One line of code, a different language, a system API call... I don't think they'd mind if you implemented that 😄

@bernaferrari
Copy link
Owner

Is it OK now?

@Madis0
Copy link
Author

Madis0 commented Apr 7, 2019

Not as of the #9 latest APK. Unless you made a new one?

@bernaferrari
Copy link
Owner

No.. So, could you please clean up data, open it, wait for sync to finish, and send me the logs?

@Madis0
Copy link
Author

Madis0 commented Apr 7, 2019

Sent. Seems like all oandbackup and ADB-installed packages have the source null, so it's not the best value to check for.

@bernaferrari
Copy link
Owner

bernaferrari commented Apr 7, 2019

Sent. Seems like all oandbackup and ADB-installed packages have the source null, so it's not the best value to check for.

Uh oh! I just changed completely from that! Reinstall is not necessary, but clean data is:
http://s000.tinyupload.com/index.php?file_id=48822454369088013120
If the counter is still wrong, by like a few values, feel free to send another email, I made some tests on log reporting that might help in the direction.

@Madis0
Copy link
Author

Madis0 commented Apr 8, 2019

It is now correct! 🎉

@bernaferrari
Copy link
Owner

Thanks!

@Madis0 Madis0 mentioned this issue Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants