Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non-Play Store apps #5

Closed
Madis0 opened this issue Nov 1, 2018 · 8 comments
Closed

Show non-Play Store apps #5

Madis0 opened this issue Nov 1, 2018 · 8 comments

Comments

@Madis0
Copy link

Madis0 commented Nov 1, 2018

I am not quite sure why you hid all apps that are not installed from Play Store, though on the other hand, hiding system apps would make sense.

@bernaferrari
Copy link
Owner

Because the target sdk restriction is only imposed on play store and if I allow system apps the number of apps increase 3 times (and so does the time to sync). But eventually, like next month or so, I'm planning to include a toggle to allow all apps. Even the database already supports it. Should be a really small change.

@Madis0
Copy link
Author

Madis0 commented Nov 1, 2018

Because the target sdk restriction is only imposed on play store

That makes it even more worthy, because with no restrictions the developers have even less reasons to update the target.

if I allow system apps the number of apps increase 3 times

I don't think you should enable showing system apps by default at least, though it can be useful to see if something changed between OTA upgrades.

@bernaferrari
Copy link
Owner

It is on the roadmap. Yesterday I completely redesigned the details dialog. I'll be focusing on this soon.

@Zebra67
Copy link

Zebra67 commented Feb 10, 2019

sir when will you add this feature

@bernaferrari
Copy link
Owner

bernaferrari commented Feb 10, 2019 via email

@bernaferrari
Copy link
Owner

bernaferrari commented Feb 27, 2019

Hey! I just implemented it (but still didn't push)!
I have, however, one question.

I added a "show system apps" toggle on Settings. When user toggles it, the app starts observing. But what happens when user toggles off, i.e., doesn't want to see system apps anymore?

I can:

  1. Remove them.
  2. Keep them and show them as if nothing happened (would ignore newer changes)
  3. Keep them and filter/ignore them when fetching things.

So, should I:

  1. Just remove the system apps that were being tracked from database without asking.
  2. Ask user between removing them or keeping them there and not showing.
  3. ???

What do you prefer? I would prefer to not have this dialog, but you are the users.

@Madis0
Copy link
Author

Madis0 commented Feb 27, 2019

Keep them and filter/ignore them when fetching things.

I'd choose this, as it seems the fastest and simplest option, no database rewriting required.

@bernaferrari
Copy link
Owner

Done! Please build the app or download the apk (on readme) and tell me if you like!
You shouldn't need to reinstall and the update should be really simple. If anything else happens, please tell me. I got some weird errors with emulator on app first install, but on my device everything has been working so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants