Select type is being sorted by the collection key

[andrerpbts]

Hi,

I'm using the best_in_place, to edit values with select type. But, I discovered that it isn't ordering like the collection I've set.

So, after some tests, I figured out if you pass the hash in this way:

<%= best_in_place @user, 
                  :country, 
                  :type => :select, 
                  :collection => {"4" => "France", "3" => "Germany", "2" => "Italy", "1" => "Spain" } %>

You'll get the result:

<option value="1">Spain</option>
<option value="2">Italy</option>
<option value="3">Germany</option>
<option value="4">France</option>

It's all happens because the JSON's parse. It's ordering by the key number, if a hash is given, see:

JSON.parse('{"4":"France", "3":"Germany", "2":"Italy", "1":"Spain"}'); 
-> Object { 1: "Spain", 2: "Italy", 3: "Germany", 4: "France" }

So, I think the right way to build this element, is using Array, like:

JSON.parse('[["4","France"], ["3","Germany"], ["2","Italy"], ["1","Spain"]]'); 

What do you think?

[stereodenis]

@andrerpbts I'm working on this

[bvogel]

@seuros Can we please reopen this? I'm still seeing the ordering issue. When building with collection: [[1, 'Spain'], [3, 'Germany'], [2, 'Italy'], [4, 'France']] the generated select will show 'Spain', 'Italy', 'Germany', 'France' - even using the provided code from the Readme. I'm on Rails 4.2 with ruby 2.1.5.

[seuros]

Try master please.

[bvogel]

Tried master - no dice. Aren't master and 3.0.3 identical in the relevant sections?

[bvogel]

@stereodenis may be 7e83193 caused a regression?

[maland]

i am also using 3.0.3 and experiencing the same problem

[stereodenis]

@andrerpbts this PR should fix right order #459