Add rpm_dist method. #190
Merged
Add rpm_dist method. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbevc1
approved these changes
Jun 23, 2017
|
Thanks for merging! When do you think it'll be available from rubygems.org? |
bernd
added a commit
that referenced
this pull request
Jul 9, 2017
Changes: * Hiera lookups of recipe data from templated YAML files. (BaxterStockman / #150) * Travis-CI build matrix improvements. (thedrow / #155) * Expose `lsbcodename` fact. (thedrow / #158) * Improved build cookie generator. (BaxterStockman / #157) * Improved facter usage. (BaxterStockman / #167) * Alpine (apk) package support. (lloydpick / #162) * Fix typos and missing tests. (lloydpick / #163) * Add `inspect` command. (BaxterStockman / #165) * json dependency fix to work with older Rubies. (BaxterStockman / #166) * Bug fix when using local directory sources. (#164) * Make vendor delimiter configurable. (#169) * Ensure consistend extracted source value from all source handlers. (#170) * Add default package version and guard against nil/empty versions. (BaxterStockman / #176) * Documenting the use of Hiera in recipes. (BaxterStockman / #184) * Ruby pre-2.0 compatibility fix. (BaxterStockman / #183) * Add "safe\_yaml" dependency. (davewongillies / #186, #154) * Add `rpm_dist` method. (sfzylad / #190)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when building RPMs for many platforms, files are getting overwritten as no Distribution Tag is set, so the RPM file name does not contain distribution version like
el6orel7which results infoobar-version.rpmfile being build for all the distributions.This change adds
rpm_distmethod to recipe file. This results in:rpm_distattribute to be set inFPM::Package::RPMand the output RPM file will be named:foobar-version.el7.rpm, givenel7is being set as content ofrpm_dist.