Merge pull request #33 from wandernauta/checker-dtor

Add virtual destructors to Checker and Notifier base classes
berthubert · Apr 5, 2024 · 5891f26 · 5891f26
2 parents 30b73ed + 239926b
commit 5891f26
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/notifiers.hh b/notifiers.hh
@@ -17,11 +17,7 @@ public:
   Notifier(bool)
   {
   }
-
-  ~Notifier()
-  {
-    //    fmt::print("A notifier was destroyed\n");
-  }
+  virtual ~Notifier() = default;
   virtual void alert(const std::string& message) = 0;
   std::string getNotifierName() { return d_notifierName; }
   void bulkAlert(const std::string& textBody);

diff --git a/simplomon.hh b/simplomon.hh
@@ -66,6 +66,7 @@ public:
     //  fmt::print("Adding notifier {}\n", n->getNotifierName());
   }
   Checker(const Checker&) = delete;
+  virtual ~Checker() = default;
   void Perform()
   {
     d_reasons = this->perform();