Add virtual destructors to Checker and Notifier base classes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkers are deleted through a smart pointer to base (the std::unique_ptr in g_checkers) so need a virtual destructor.
This is not strictly necessary as Notifiers are managed through std::shared_ptr only, but do so anyway for consistency with Checker.
|
good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkers are kept in a
vector<unique_ptr<Checker>>. If they were ever removed from that vector, they would be deleted through a base pointer. Since the different Checker subclasses have different fields and sizes, those would then not be correctly cleaned up.The
Notifierbase class is then changed for consistency.