Skip to content

Commit

Permalink
2.4.4 release, removing UID variants of Pop3Client.DeleteMessage whic…
Browse files Browse the repository at this point in the history
…h didn't work.
  • Loading branch information
bertjohnson committed Feb 16, 2017
1 parent 0d9798e commit 77961dd
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 67 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Original file line Diff line number Diff line change
@@ -1,5 +1,8 @@
### Changelog ### ### Changelog ###


2.4.4 - 2017-02-16
* Removed UID variants of `Pop3Client.DeleteMessage`, as deletion only works based on index.

2.4.3 - 2017-01-09 2.4.3 - 2017-01-09
* Fixed bug when headers contained high-byte characters after the 78th index. * Fixed bug when headers contained high-byte characters after the 78th index.


Expand Down
4 changes: 2 additions & 2 deletions OpaqueMail.CertHelper/Properties/AssemblyInfo.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@
// You can specify all the values or you can default the Build and Revision Numbers // You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below: // by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2.4.3")] [assembly: AssemblyVersion("2.4.4")]
[assembly: AssemblyFileVersion("2.4.3")] [assembly: AssemblyFileVersion("2.4.4")]
4 changes: 2 additions & 2 deletions OpaqueMail.Proxy/Properties/AssemblyInfo.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@
// You can specify all the values or you can default the Build and Revision Numbers // You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below: // by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2.4.3")] [assembly: AssemblyVersion("2.4.4")]
[assembly: AssemblyFileVersion("2.4.3")] [assembly: AssemblyFileVersion("2.4.4")]
4 changes: 2 additions & 2 deletions OpaqueMail.ProxyService/Properties/AssemblyInfo.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@
// You can specify all the values or you can default the Build and Revision Numbers // You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below: // by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2.4.3")] [assembly: AssemblyVersion("2.4.4")]
[assembly: AssemblyFileVersion("2.4.3")] [assembly: AssemblyFileVersion("2.4.4")]
4 changes: 2 additions & 2 deletions OpaqueMail.ProxySettings/Properties/AssemblyInfo.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@
// You can specify all the values or you can default the Build and Revision Numbers // You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below: // by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2.4.3")] [assembly: AssemblyVersion("2.4.4")]
[assembly: AssemblyFileVersion("2.4.3")] [assembly: AssemblyFileVersion("2.4.4")]
4 changes: 2 additions & 2 deletions OpaqueMail.TestClient/Properties/AssemblyInfo.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@
// You can specify all the values or you can default the Build and Revision Numbers // You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below: // by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2.4.3")] [assembly: AssemblyVersion("2.4.4")]
[assembly: AssemblyFileVersion("2.4.3")] [assembly: AssemblyFileVersion("2.4.4")]
2 changes: 1 addition & 1 deletion OpaqueMail.doxygen
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ PROJECT_NAME = "OpaqueMail"
# could be handy for archiving the generated documentation or if some version # could be handy for archiving the generated documentation or if some version
# control system is used. # control system is used.


PROJECT_NUMBER = 2.4.3 PROJECT_NUMBER = 2.4.4


# Using the PROJECT_BRIEF tag one can provide an optional one line description # Using the PROJECT_BRIEF tag one can provide an optional one line description
# for a project that appears at the top of each page and should give viewer a # for a project that appears at the top of each page and should give viewer a
Expand Down
54 changes: 0 additions & 54 deletions OpaqueMail/Pop3/Pop3Client.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -297,15 +297,6 @@ public bool DeleteMessage(int index)
return Task.Run(() => DeleteMessageAsync(index)).Result; return Task.Run(() => DeleteMessageAsync(index)).Result;
} }


/// <summary>
/// Delete a message from the server based on its index.
/// </summary>
/// <param name="uid">UID of the message to delete.</param>
public bool DeleteMessageUid(string uid)
{
return Task.Run(() => DeleteMessageAsync(uid)).Result;
}

/// <summary> /// <summary>
/// Delete a message from the server based on its index. /// Delete a message from the server based on its index.
/// </summary> /// </summary>
Expand All @@ -321,21 +312,6 @@ public async Task<bool> DeleteMessageAsync(int index)
return LastCommandResult; return LastCommandResult;
} }


/// <summary>
/// Delete a message from the server based on its UID.
/// </summary>
/// <param name="uid">UID of the message to delete.</param>
public async Task<bool> DeleteMessageAsync(string uid)
{
// Protect against commands being called out of order.
if (!IsAuthenticated)
throw new Pop3Exception("Must be connected to the server and authenticated prior to calling the DELE command.");

await SendCommandAsync("DELE " + uid + "\r\n");
await ReadDataAsync();
return LastCommandResult;
}

/// <summary> /// <summary>
/// Delete a series of messages from the server based on their indices. /// Delete a series of messages from the server based on their indices.
/// </summary> /// </summary>
Expand Down Expand Up @@ -366,36 +342,6 @@ public async Task<bool> DeleteMessagesAsync(int[] indices)
return returnValue; return returnValue;
} }


/// <summary>
/// Delete a series of messages from the server based on their UIDs.
/// </summary>
/// <param name="uids">Array of message UIDs to delete.</param>
public bool DeleteMessages(string[] uids)
{
return Task.Run(() => DeleteMessagesAsync(uids)).Result;
}

/// <summary>
/// Delete a series of messages from the server based on their UIDs.
/// </summary>
/// <param name="uids">Array of message UIDs to delete.</param>
public async Task<bool> DeleteMessagesAsync(string[] uids)
{
// Protect against commands being called out of order.
if (!IsAuthenticated)
throw new Pop3Exception("Must be connected to the server and authenticated prior to calling the DELE command.");

bool returnValue = true;
foreach (string uid in uids)
{
await SendCommandAsync("DELE " + uid + "\r\n");
await ReadDataAsync();
returnValue &= LastCommandResult;
}

return returnValue;
}

/// <summary> /// <summary>
/// Sends a QUIT message to the POP3 server, gracefully ends the TCP connection, and releases all resources used by the current instances of the OpaqueMail.Pop3Client class. /// Sends a QUIT message to the POP3 server, gracefully ends the TCP connection, and releases all resources used by the current instances of the OpaqueMail.Pop3Client class.
/// </summary> /// </summary>
Expand Down
4 changes: 2 additions & 2 deletions OpaqueMail/Properties/AssemblyInfo.cs
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@
// You can specify all the values or you can default the Build and Revision Numbers // You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below: // by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")] // [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2.4.3")] [assembly: AssemblyVersion("2.4.4")]
[assembly: AssemblyFileVersion("2.4.3")] [assembly: AssemblyFileVersion("2.4.4")]

0 comments on commit 77961dd

Please sign in to comment.