Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No such property: file for class: asset.pipeline.grails.AssetPipelineFilter #379

Closed
tvirtualw opened this issue Nov 9, 2016 · 0 comments
Closed

No such property: file for class: asset.pipeline.grails.AssetPipelineFilter #379

tvirtualw opened this issue Nov 9, 2016 · 0 comments

Comments

@tvirtualw
Copy link 

groovy.lang.MissingPropertyException: No such property: file for class: asset.pipeline.grails.AssetPipelineFilter
	at asset.pipeline.grails.AssetPipelineFilter.hasNotChanged(AssetPipelineFilter.groovy:211)
	at asset.pipeline.grails.AssetPipelineFilter.doFilter(AssetPipelineFilter.groovy:61)

In method asset.pipeline.grails.AssetPipelineFilter#hasNotChanged a file property is accessed in hasNotChanged = new Date(file?.lastModified()) <= sdf.parse(ifModifiedSince) which does not exist and it causes two issues: 1) most likely the caching logic does not work and 2) stacktraces get logged in tremendous amounts.

Applies to version 2.9.1. It seems the same problem is still present on master.
sbearcsiro added a commit to sbearcsiro/grails-asset-pipeline that referenced this issue Jan 9, 2017
@sbearcsiro
Fix bertramdev#379
8751561 
 - Give last modified date to AssetPipelineResponseBuilder
 - Remove special last modified date handling from AssetPipelineFilter as AssetPipelineResponseBuilder handles it now
 - Remove now unused methods hasNotChanged and getLastModifiedDate
sbearcsiro added a commit to sbearcsiro/grails-asset-pipeline that referenced this issue Jan 9, 2017
@sbearcsiro
Fix bertramdev#379
c165a4b 
 - Give last modified date to AssetPipelineResponseBuilder
 - Remove special last modified date handling from AssetPipelineFilter as AssetPipelineResponseBuilder handles it now
 - Remove now unused methods hasNotChanged and getLastModifiedDate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tvirtualw