Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UX - Go back to contact list when remove contact #1326

Merged
merged 1 commit into from Aug 28, 2019
Merged

[BUG] UX - Go back to contact list when remove contact #1326

merged 1 commit into from Aug 28, 2019

Conversation

90dy
Copy link
Member

@90dy 90dy commented Aug 27, 2019

No description provided.

@90dy 90dy added the bug type: something isn't working label Aug 21, 2019
@90dy 90dy mentioned this pull request Aug 21, 2019
5 tasks
@90dy 90dy requested a review from a team as a code owner August 27, 2019 14:37
@90dy 90dy changed the title [BUG] UX - Go back to contact list when remove contact WIP [BUG] UX - Go back to contact list when remove contact Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1326 into master will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
+ Coverage   28.75%   28.87%   +0.11%     
==========================================
  Files          72       72              
  Lines        5961     5961              
==========================================
+ Hits         1714     1721       +7     
+ Misses       3961     3952       -9     
- Partials      286      288       +2
Impacted Files Coverage Δ
core/node/nodeapi.go 5.57% <0%> (ø) ⬆️
core/node/p2pclient.go 45.45% <0%> (-3.04%) ⬇️
core/crypto/enclave/generic_keystore.go 42.22% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6807b79...d047dbc. Read the comment docs.

@90dy 90dy changed the title WIP [BUG] UX - Go back to contact list when remove contact [BUG] UX - Go back to contact list when remove contact Aug 28, 2019
@90dy 90dy self-assigned this Aug 28, 2019
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type: something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants