Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UI - Popup infinite restart http error 400 or 500 #1358

Merged
merged 2 commits into from Sep 6, 2019
Merged

[BUG] UI - Popup infinite restart http error 400 or 500 #1358

merged 2 commits into from Sep 6, 2019

Conversation

90dy
Copy link
Member

@90dy 90dy commented Sep 5, 2019

Seems that HTTP for update not handle when activate airplane mode and display restart popup error unhandled error http response at 400 or 500 level infinitely

@90dy 90dy added the important label Sep 4, 2019
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy 90dy requested a review from a team as a code owner September 5, 2019 12:36
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #1358 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
- Coverage    28.9%   28.72%   -0.19%     
==========================================
  Files          72       72              
  Lines        5961     5961              
==========================================
- Hits         1723     1712      -11     
- Misses       3950     3963      +13     
+ Partials      288      286       -2
Impacted Files Coverage Δ
core/crypto/enclave/generic_keystore.go 32.22% <0%> (-10%) ⬇️
core/node/p2pclient.go 45.45% <0%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9d65d...f6cd82b. Read the comment docs.

@90dy 90dy self-assigned this Sep 5, 2019
@90dy 90dy merged commit 468f0e7 into berty:master Sep 6, 2019
@90dy 90dy deleted the fix-1358 branch September 6, 2019 07:41
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant