Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rn): start daemon #642

Merged
merged 18 commits into from
Nov 27, 2018
Merged

refactor(rn): start daemon #642

merged 18 commits into from
Nov 27, 2018

Conversation

90dy
Copy link
Member

@90dy 90dy commented Nov 22, 2018 •
edited by moul-bot

fix #625
fix #624

@90dy 90dy requested a review from a team as a code owner November 22, 2018 09:29
@90dy 90dy self-assigned this Nov 22, 2018
@90dy 90dy added this to the w18.47 🌳 milestone Nov 22, 2018
@codecov
Copy link

codecov bot commented Nov 22, 2018 •
edited

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   22.24%   22.24%           
=======================================
  Files          50       50           
  Lines        2805     2805           
=======================================
  Hits          624      624           
  Misses       2034     2034           
  Partials      147      147
Impacted Files Coverage Δ
core/node/p2pclient.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af249b...7a9a055. Read the comment docs.

@alexsland alexsland modified the milestones: w18.47 🌳, w18.48 🌧️ Nov 26, 2018
@guardrails
Copy link

guardrails bot commented Nov 26, 2018 •
edited

⚠️ We detected security issues in this pull request:

Hard-Coded Secrets (1)

More info on how to fix Hard-Coded Secrets in General.

@glouvigny glouvigny mentioned this pull request Nov 26, 2018
Merged
@90dy 90dy changed the title wip: refactor: start daemon refactor(rn): start daemon Nov 26, 2018
@90dy
refactor(rn): start daemon
c0c664c 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): add contact deep link
158f9f7 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): start daemon
8332bcd 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
refactor(relay): environment as injection dependency
613c4df 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(relay): subscriptions with dependency injection
6ed7289 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): queries with injection dependency
127b223 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
refactor(rn): updaters
2eeb2ec 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): add public key
a7c4d65 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): generic updater
d641d0e 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): conversation new message updater
290461e 
fix #624

Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): display status to contact list
6ed62b7 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): contact request and remove updates
293f9ce 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): contact request and remove updates
07da48b 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): devtools, settings and conversation details and list screens
6550222 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): fix available update
db7f4b8 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(gomobile): use net instead of reuse
a37092b 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(rn): react context and pagination refetch
69b1892 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy
fix(web): react-relay-network-modern compilation
7a9a055 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
aeddi
aeddi approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@aeddi aeddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@90dy 90dy merged commit 4d2e37e into berty:master Nov 27, 2018
@90dy 90dy deleted the refactor/gponsinet/rn-daemon-start-app-2 branch December 12, 2018 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeddi aeddi aeddi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
w18.48 🌧️
Development

Successfully merging this pull request may close these issues.

Refactor start daemon Fix messages that are not updated in live (requires a reboot of the app)
3 participants
@90dy @aeddi @alexsland