Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shouldExclude method #55

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Mar 4, 2022

fix: concurrency

@gfanton gfanton requested a review from a team as a code owner March 4, 2022 09:39
@auto-add-label auto-add-label bot added the bug Something isn't working label Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #55 (1cbc1c4) into master (9767abc) will increase coverage by 0.69%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   67.81%   68.51%   +0.69%     
==========================================
  Files          21       23       +2     
  Lines        1805     1826      +21     
==========================================
+ Hits         1224     1251      +27     
+ Misses        369      368       -1     
+ Partials      212      207       -5     
Flag Coverage Δ
unittests 68.51% <91.66%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
entry/fetcher.go 87.61% <87.61%> (ø)
entry/entry_io.go 100.00% <100.00%> (+18.75%) ⬆️
entry/queue.go 100.00% <100.00%> (ø)
log.go 67.07% <100.00%> (+0.13%) ⬆️
log_io.go 64.12% <100.00%> (+0.55%) ⬆️
entry/entry.go 76.49% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9767abc...1cbc1c4. Read the comment docs.

@gfanton gfanton self-assigned this Mar 4, 2022
@gfanton gfanton changed the title fix: fetching feat: add shouldExclude method Mar 4, 2022
@auto-add-label auto-add-label bot added enhancement New feature or request and removed bug Something isn't working labels Mar 4, 2022
fix concurrency in entry_io

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@trafico-bot trafico-bot bot added ✅ Approved Feature request has been approved and removed 🔍 Ready for Review labels Mar 4, 2022
@gfanton gfanton merged commit d5cc06a into berty:master Mar 4, 2022
@gfanton gfanton deleted the feat/fix-fetching branch March 4, 2022 14:24
@trafico-bot trafico-bot bot added ✨ Merged and removed ✅ Approved Feature request has been approved labels Mar 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants