Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused CODEOWNERS #86

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

jefft0
Copy link
Collaborator

@jefft0 jefft0 commented Apr 18, 2023

The CODEOWNERS file is used to automatically assign reviewers when the pull request is created, including groups of people. There are many pull requests which still have these reviewers assigned who are not reviewing. This doesn't make sense. It is better to communicate with a specific dev who agrees to review. Therefore we remove the CODEOWNERS file.

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@jefft0 jefft0 requested a review from D4ryl00 April 18, 2023 07:44
@jefft0 jefft0 requested a review from a team as a code owner April 18, 2023 07:44
@jefft0 jefft0 removed the request for review from a team April 18, 2023 07:44
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2cf0c40) 68.98% compared to head (3f09a8a) 68.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   68.98%   68.98%           
=======================================
  Files          23       23           
  Lines        1828     1828           
=======================================
  Hits         1261     1261           
  Misses        369      369           
  Partials      198      198           
Flag Coverage Δ
unittests 68.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trafico-bot trafico-bot bot added the ✅ Approved Feature request has been approved label Apr 18, 2023
@jefft0 jefft0 merged commit 3ef7460 into berty:master Apr 18, 2023
@jefft0 jefft0 deleted the chore/remove-CODEOWNERS branch April 18, 2023 10:18
@trafico-bot trafico-bot bot added ✨ Merged and removed ✅ Approved Feature request has been approved labels Apr 18, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants