Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension doesn't work with CODE OWNERS feature #110

Closed
RussKie opened this issue Apr 30, 2020 · 7 comments
Closed

Extension doesn't work with CODE OWNERS feature #110

RussKie opened this issue Apr 30, 2020 · 7 comments

Comments

@RussKie
Copy link

RussKie commented Apr 30, 2020

Hi there,
Looks like GitHub updated the markup again and your wonderful extensions isn't working

Uncaught TypeError: Cannot read property 'parentElement' of null
    at u (better_github_prs.js:1)
    at s (better_github_prs.js:1)
    at better_github_prs.js:1
    at Array.forEach (<anonymous>)
    at better_github_prs.js:1
    at Array.forEach (<anonymous>)
    at b (better_github_prs.js:1)
    at n.value (better_github_prs.js:31)
    at n.value (better_github_prs.js:31)
    at La (better_github_prs.js:22)
@mychaelgo
Copy link
Contributor

looks like it's not working on private repository, but working on public repository 🤔

@RussKie
Copy link
Author

RussKie commented May 1, 2020

Nop, https://github.com/dotnet/winforms/pull/3064/files
image

Microsoft Edge: Version 81.0.416.68 (Official build) (64-bit)

@mychaelgo
Copy link
Contributor

mychaelgo commented May 1, 2020

i see, i check that broken for repository with CODEOWNERS file, hrefSplit return wrong fileId

@mychaelgo
Copy link
Contributor

@RussKie already create PR here #111
Once it release by @berzniz , this issue should be solved. I face the same problem before.

@berzniz
Copy link
Owner

berzniz commented May 1, 2020

Thanks for the fix, I'll try to get it out as soon as possible.

As always, you can install the branch with the fix until then

@berzniz
Copy link
Owner

berzniz commented May 1, 2020

Will be fixed in 1.0.30 (deploying today to the Chrome/Firefox web stores)

@mychaelgo
Copy link
Contributor

thanks @berzniz

@berzniz berzniz changed the title Broken again Extension doesn't work with CODE OWNERS feature May 1, 2020
@berzniz berzniz closed this as completed May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants