Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fileId when CODEOWNERS exists #111

Closed
wants to merge 1 commit into from

Conversation

mychaelgo
Copy link
Contributor

@mychaelgo mychaelgo commented May 1, 2020

fix #110

Screenshot

Screen Shot 2020-05-01 at 08 48 06

@berzniz please help to review & test. working fine on my Chrome Mac 🙏

@RussKie
Copy link

RussKie commented May 1, 2020

Interestingly enough it is working in this repo:
image

...but not working in dotnet repos for me. Here's another repo:
e.g. https://github.com/dotnet/roslyn-analyzers/pull/3588/files
image

I ran the selectors - both old and the new - in this PR:
image

...and in https://github.com/dotnet/winforms/pull/3064/files - they both are working too:
image
image

So I think there may be something else that's not working.

@mychaelgo
Copy link
Contributor Author

mychaelgo commented May 1, 2020

@RussKie

it works for me on https://github.com/dotnet/roslyn-analyzers/pull/3588/files
Screenshot
Screen Shot 2020-05-01 at 09 08 35

@mychaelgo
Copy link
Contributor Author

Screen Shot 2020-05-01 at 09 21 01

and there is different result between .file-info > a.link-gray-dark & .file-info > a

  • .file-info > a.link-gray-dark get the correct fileid only
  • .file-info > a get the correct fileid & CODEOWNER element

@RussKie
Copy link

RussKie commented May 1, 2020

Thank you 👍
My JS and CSS are pretty basic

@berzniz
Copy link
Owner

berzniz commented May 1, 2020

Hi @mychaelgo -- I've suggested an alternative solution in #113 . The benefit is to make it future proof (as much as possible), so if other a links appear they will not break the extension.

Comments and feedback are welcomed

@berzniz
Copy link
Owner

berzniz commented May 1, 2020

Thanks for the PR and all the effort with testing and providing examples. We will use the fix from #113

@berzniz berzniz closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension doesn't work with CODE OWNERS feature
3 participants