-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selected item out of sync #118
Comments
Thanks for reporting. It seems like GitHub doesn't scroll all the way when navigating using links (URL change), so it goes out of sync. If anyone wants to try and fix it, I'll appreciate a PR |
I'd love to help with this. My understanding is that the tree highlights the first file visible in the viewport. github_pr_tree/src/js/components/tree/index.jsx Lines 121 to 126 in 42f2f05
To fix this, I would suggest prioritising an element with the The behaviour would feel more natural: clicking on the tree item would select the right one, and scrolling up the page would scroll up in the tree as well. |
#118 Fix tree desync by taking :target into consideration
Will be in included in 1.0.32 |
The selected item in the tree seems to be out of sync and typically not the item I clicked on.
It seems like a bug to me but opening an issue to track this nevertheless and to get some feedback from others.
The text was updated successfully, but these errors were encountered: