Selected item out of sync

[Hacksore]

The selected item in the tree seems to be out of sync and typically not the item I clicked on.

It seems like a bug to me but opening an issue to track this nevertheless and to get some feedback from others.

[berzniz]

Thanks for reporting. It seems like GitHub doesn't scroll all the way when navigating using links (URL change), so it goes out of sync.

If anyone wants to try and fix it, I'll appreciate a PR

[aramperes]

I'd love to help with this. My understanding is that the tree highlights the first file visible in the viewport.

github_pr_tree/src/js/components/tree/index.jsx

Lines 121 to 126 in 42f2f05

	const nextVisibleElement = diffElements.find(isElementVisible)
	if (nextVisibleElement !== visibleElement) {
	this.setState({
	visibleElement: nextVisibleElement
	})
	}

To fix this, I would suggest prioritising an element with the :target pseudo-class, and check if it's in the viewport. If it's not, default back to the current logic (first visible file).

The behaviour would feel more natural: clicking on the tree item would select the right one, and scrolling up the page would scroll up in the tree as well.

[berzniz]

Will be in included in 1.0.32