Changing wormhole router to use bsg_noc_links instead of ready-valid #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion makes wormhole router no longer backward compatible!
gaozihou
reviewed
May 21, 2019
dpetrisko
force-pushed
the
wormhole_bsg_noc_link
branch
from
88ce58f
to
9b0ed7e
Compare
|
Good idea, fixed! |
gaozihou
approved these changes
May 21, 2019
|
looks fine. if you plan to buffer adapter in with bsg_two_fifo, it should probably go between adapter and router, not between LCE and adapter |
tommydcjung
approved these changes
May 21, 2019
|
Good call, I’ll move it there for consistency |
|
Can we merge this in? |
farzamgl
reviewed
May 22, 2019
dpetrisko
force-pushed
the
wormhole_bsg_noc_link
branch
from
9b0ed7e
to
30edc4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the wormhole_router and _adapters to use bsg_noc links on the network side. The testbenches have been updated to work with the new interface and I've tested the whole system with new links on BlackParrot in a separate branch there.