Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week 3 - implement a button to delete all comments from the database #8

Merged
merged 12 commits into from
Jul 30, 2020
Merged

Week 3 - implement a button to delete all comments from the database #8

merged 12 commits into from
Jul 30, 2020

Conversation

bessmarche
Copy link
Owner

  • create a new servlet: DeleteServlet.java with a doPost method to iterate trough the comment entities in the database and delete them
  • add a function fetchDeleteData() in script.js that sends a POST request every time the user clicks the delete button
  • add a delete button under the comment section in the homepage

jtangelder
jtangelder requested changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@jtangelder jtangelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment to fix a race condition!

Base automatically changed from featureNumberofComm to master July 22, 2020 16:25
@bessmarche bessmarche requested review from ramaroberto and removed request for jtangelder July 27, 2020 06:39
ramaroberto
ramaroberto requested changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@ramaroberto ramaroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once you resolve the comments!

portfolio/src/main/webapp/script.js Outdated Show resolved Hide resolved
portfolio/src/main/webapp/script.js Outdated Show resolved Hide resolved
@jtangelder jtangelder self-requested a review July 30, 2020 07:58
@bessmarche bessmarche merged commit 4d7da72 into master Jul 30, 2020
@bessmarche bessmarche deleted the featureDelete branch July 30, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaroberto ramaroberto ramaroberto approved these changes

@jtangelder jtangelder jtangelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bessmarche @ramaroberto @jtangelder