Skip to content

Commit

Permalink
Do not retry processing ActivityPub jobs raising validation errors (m…
Browse files Browse the repository at this point in the history
…astodon#10614)

* Do not retry processing ActivityPub jobs raising validation errors

Jobs yielding validation errors most probably won't ever be accepted,
so it makes sense not to clutter the queues with retries.

* Lower RecordInvalid error reporting to debug log level

* Remove trailing whitespace
  • Loading branch information
ClearlyClaire authored and rosylilly committed May 4, 2019
1 parent 7270a1c commit 301205b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions app/workers/activitypub/processing_worker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ class ActivityPub::ProcessingWorker

def perform(account_id, body, delivered_to_account_id = nil)
ActivityPub::ProcessCollectionService.new.call(body, Account.find(account_id), override_timestamps: true, delivered_to_account_id: delivered_to_account_id, delivery: true)
rescue ActiveRecord::RecordInvalid => e
Rails.logger.debug "Error processing incoming ActivityPub object: #{e}"
end
end

0 comments on commit 301205b

Please sign in to comment.