Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reenable network e2e test #187

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: reenable network e2e test #187

merged 1 commit into from
Mar 15, 2023

Conversation

Abirdcfly
Copy link
Member

Fix #186

@Abirdcfly Abirdcfly force-pushed the fixnetworke2e branch 21 times, most recently from 52c3936 to a573e01 Compare March 14, 2023 10:36
@Abirdcfly
fix: reenable network e2e test
b382f28 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@Abirdcfly Abirdcfly marked this pull request as ready for review March 15, 2023 02:01
bjwswang
bjwswang approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@bjwswang bjwswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bjwswang bjwswang merged commit 88ef5f6 into bestchains:main Mar 15, 2023
@Abirdcfly Abirdcfly deleted the fixnetworke2e branch March 15, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjwswang bjwswang bjwswang approved these changes

@nkwangleiGIT nkwangleiGIT Awaiting requested review from nkwangleiGIT

@0xff-dev 0xff-dev Awaiting requested review from 0xff-dev

@Lanture1064 Lanture1064 Awaiting requested review from Lanture1064

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample Network E2E Test not running properly in the last month.
2 participants
@Abirdcfly @bjwswang