Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plainText and size props for Input #582

Open
igorsantos07 opened this issue Dec 6, 2023 · 0 comments
Open

Add plainText and size props for Input #582

igorsantos07 opened this issue Dec 6, 2023 · 0 comments
Labels
Priority: Low Bug, issue, or pull request is a P3 Severity: Low Bug or issue is of low severity Type: Bug Something isn't working

Comments

@igorsantos07
Copy link

igorsantos07 commented Dec 6, 2023 •
edited
Loading

Read-only inputs which should not show as actual inputs have a different class, and currently it's not possible to implement them with the Input component - since using class="form-control form-control-plaintext" causes funny issues if you try to focus it haha

Also, I noticed the Input component is missing the size property, similar to what's already available in Button - it's not a mandatory prop as plainText would be, but nonetheless would help the Input feel more "at home" and paired with other components which have that prop.
@igorsantos07 igorsantos07 changed the title Plain-text, read-only inputs: add "plaintext" as a property for Input Add plaintext and size props for Input Dec 6, 2023
@igorsantos07 igorsantos07 changed the title Add plaintext and size props for Input Add plainText and size props for Input Dec 6, 2023
igorsantos07 added a commit to igorsantos07/clockify-targets that referenced this issue Dec 6, 2023
@igorsantos07
fix #5: add money-related Settings
c4a9d8d 
Also:
- adds some missing Bootstrap variables/configs, needed for a more complex form such as the Settings page
- adds a LOT of options to Linput - affixes, size, fullWidth, help prop/slot, and plainText (see bestguy/sveltestrap#582)
@dysfunc dysfunc added Priority: Low Bug, issue, or pull request is a P3 Severity: Low Bug or issue is of low severity Type: Bug Something isn't working labels Dec 6, 2023
igorsantos07 added a commit to igorsantos07/clockify-targets that referenced this issue Dec 10, 2023
@igorsantos07
close #5, #16: add money-related Settings
73df341 
Also:
- adds some missing Bootstrap variables/configs, needed for a more complex form such as the Settings page
- adds a LOT of options to Linput - affixes, size, fullWidth, help prop/slot, and plainText (see bestguy/sveltestrap#582)
igorsantos07 added a commit to igorsantos07/clockify-targets that referenced this issue Dec 10, 2023
@igorsantos07
close #5, close #16: add money-related Settings
49a43e1 
Also:
- adds some missing Bootstrap variables/configs, needed for a more complex form such as the Settings page
- adds a LOT of options to Linput - affixes, size, fullWidth, help prop/slot, and plainText (see bestguy/sveltestrap#582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Bug, issue, or pull request is a P3 Severity: Low Bug or issue is of low severity Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igorsantos07 @dysfunc