fix/DEN-299 optionally allow keys for tax-categories #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedrix-bestit
force-pushed
the
fix/DEN-299-optionally-key-for-taxcategories
branch
from
7ccff8b
to
644e007
Compare
b3nl
suggested changes
Mar 6, 2020
| * @param mixed $changedValue | ||
| * @param ClassMetadataInterface $metadata | ||
| * @param array $changedData | ||
| * @param array $oldData | ||
| * @param mixed $sourceObject | ||
| * | ||
| * @return AbstractAction[] | ||
| * @todo The documentation does not tell of the staged param in the action. what does that mean? |
There was a problem hiding this comment.
Please revert to default style guide.
| */ | ||
| public function createUpdateActions( | ||
| $changedValue, | ||
| ClassMetadataInterface $metadata, | ||
| array $changedData, | ||
| array $oldData, | ||
| $sourceObject | ||
| ): array { | ||
| ): array |
| $action = new ProductSetTaxCategoryAction(); | ||
|
|
||
| if ($changedValue) { | ||
| $action->setTaxCategory(TaxCategoryReference::ofId($changedValue['id'])); | ||
| if (isset($changedValue['id']) && $changedValue['id'] !== null) { |
There was a problem hiding this comment.
Please remove the double null check.
| $action->setTaxCategory(TaxCategoryReference::ofId($changedValue['id'])); | ||
| } else { | ||
| if (isset($changedValue['key']) && $changedValue['key'] !== null) { | ||
| $action->setTaxCategory(TaxCategoryReference::ofKey($changedValue['key'])); |
There was a problem hiding this comment.
If the reference with keyw work now, then this is fine for me.
|
(and this is no fix, but a feature). |
|
Since I couldn't update the branch to add the tests, I've created a new PR (#48) and am closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that tax-categories are null (which is not allowed) by either using id's or keys (new), if there is no id given. This is necessary for DEN-299.
Lars Neujeffski