Skip to content

Commit

Permalink
* Rework error handling. Mason's dhandler is no longer in charge of
Browse files Browse the repository at this point in the history
   generating 404's; instead, the dispatcher catches when no views can
   handle a request.

 * Relatedly, don't bother catching, popping the buffer stack, and
   rethrowing on every error.  Instead, explicitly _don't_ pop the
   stack, and use the frames that remain on the stack when we catch it
   in the dispatcher to show a stack trace.

 * Rename 'mason_internal_error' to the more straightforward
   '/errors/500', and have ErrorTemplates do the right thing.

git-svn-id: svn+ssh://svn.bestpractical.com/svn/jifty.org/jifty/trunk@6311 e84bef0a-9b06-0410-84ba-c4c9edb13aeb
  • Loading branch information
alexmv committed Feb 5, 2009
1 parent b6bf21c commit e342c74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Jifty/Plugin/EmailErrors/Dispatcher.pm
Expand Up @@ -4,7 +4,7 @@ use warnings;
package Jifty::Plugin::EmailErrors::Dispatcher;
use Jifty::Dispatcher -base;

after '/__jifty/error/mason_internal_error', run {
after ['/__jifty/error/mason_internal_error', '/errors/500'], run {
return if already_run;
return unless Jifty->web->request->continuation;
Jifty::Plugin::EmailErrors::Notification::EmailError->new->send;
Expand Down

0 comments on commit e342c74

Please sign in to comment.