Skip to content

Commit

Permalink
Avoid sending blank lines at the top of responses
Browse files Browse the repository at this point in the history
Because of a trailing newline in this file, when RT served images from
the non-static-handler, it would inject a blank line at the top of the
file, breaking it.  This caused custom logos and charts from search
results to fail to render.

This was caused when eeb05b8 lost the return; at the end of init,
allowing the blank line to be printed.

This restores the return, with a helpful comment for the future and also
futureproofs by removing the blank lines.
  • Loading branch information
jibsheet committed Oct 16, 2014
1 parent 9ab3c84 commit 36768ca
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion html/Elements/DoAuth
Expand Up @@ -14,9 +14,11 @@ if ( $val ) {
RT::Interface::Web::Redirect( $next )
if $val and $next
and $m->request_comp->path eq '/NoAuth/Login.html';

# this component should never generate content
return;
</%init>
<%ARGS>
$user => undef
$pass => undef
</%ARGS>

0 comments on commit 36768ca

Please sign in to comment.