Fix that search result tr classes are applied on NEWLINE in Row callback #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'm writing an extension which highlights search result rows on specific conditions. This can be handled with using the
Row
callback and setting the$Classes
reference, resulting in an additional CSS class for e.g. adding a background color.Sample code:
Version
RT 4.4.3 4df308e
Problem
This works for the first line. When the search result is split up with
NEWLINE
in between, the secondarylist-item
is printed without the overridden class.Fix
Add the
Classes
variable into the condition for newlines too.